Mandarin Soda

The tag_counts instance method appears broken. I don’t have time to submit a patch right now, so I figured I’d write a quick post for others running into this issue. What I’m seeing is that if you try to access the tag_counts instance method (ie: @post.tag_counts), you’ll see a good times SQL exception much like the following:
(SQLite3::SQLException: near ")": syntax error: SELECT tags.id, tags.name, COUNT(*) AS count FROM "tags" INNER JOIN taggings ON tags.id = taggings.tag_id INNER JOIN posts ON posts.id = taggings.taggable_id WHERE (() AND taggings.taggable_type = 'Post') GROUP BY tags.id, tags.name HAVING COUNT(*) > 0):
, as the conditions builder doesn’t seem to take the model instance id into account when building the query.

The quick and dirty is to roll your own and add it to the model in question, and even this can probably be improved:
TAG_COUNT_SQL = "SELECT tags.id, tags.name, COUNT(*) AS count FROM tags INNER JOIN taggings ON tags.id = taggings.tag_id INNER JOIN posts ON posts.id = taggings.taggable_id WHERE ((posts.id = ?) AND taggings.taggable_type = 'Post') GROUP BY tags.id, tags.name HAVING COUNT(*) > 0 "

I’ve been running into enough plugin issues recently, that I’m definitely moving much closer to the always roll your own ideology as I use Rails more frequently…but, it does depend upon the use case the plugin is trying to solve. Some plugins are eminently malleable (as opposed to monkey patchable, and there is a difference), and thats a great feature.

This entry was posted on Saturday, April 26th, 2008 at 4:13 pm and is filed under Programming, Rails. You can follow any responses to this entry through the RSS 2.0 feed. You can leave a response, or trackback from your own site.